This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Upgrading to webpack v4.28.2 to support dynamic imports #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kepta
reviewed
Jun 3, 2019
examples/fancy/src/dynamic.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| function dynamic() { | |||
| console.log('hi i am a dynamic import'); | |||
Contributor
There was a problem hiding this comment.
@elifitch instead of console logging can we show a UI change in the ./fancy/src/app.js component.
kepta
approved these changes
Jun 3, 2019
Contributor
kepta
left a comment
kepta
left a comment
There was a problem hiding this comment.
Looks great 👍 , thanks for fixing this.
Contributor
Author
|
@kepta how should we go about merging and releasing this? |
Contributor
|
@elifitch you can merge it and then:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to webpack
4.28.2and pegs us at that version for the time being. The problem here is that newer versions of webpack have hard-to-diagnose problems with dynamic imports. Per this issue webpack/webpack#8656 there are workarounds one can take at the project level, and for some, using yarn instead of npm has rectified the problem. This is kind of a blanket approach, as it just pegs us at the version before this problem was introduced.I didn't write any tests to confirm that dynamic imports work, as it was a bit difficult for me to come to grips with the underreact test suite. I did however include a dynamic import in the
fancy/example.Either @kepta or @davidtheclark for review ❤️