-
Notifications
You must be signed in to change notification settings - Fork 14
Filter prefixes #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter prefixes #293
Changes from all commits
9e1b28d
d46ae3e
bd5e599
1758210
5ff2f51
eb5e087
ed76c7f
8d40ecc
a026c27
5720c82
fc067b2
eec62c2
6ef286a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -360,6 +360,8 @@ def filter_file(input: str, output: TextIO, **kwargs) -> MappingSetDataFrame: | |
| for exp in v[1:]: | ||
| query += " OR " | ||
| query += k + " LIKE '" + exp + "') " | ||
| else: | ||
| query += ") " | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is new, I assume there was no test for the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was missing and became apparent when only 1 value to a param was given for e.g. |
||
| if multiple_params and idx != len(params): | ||
| query += " AND (" | ||
| return run_sql_query(query=query, inputs=[input], output=output) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, we can later consider making this multivalued (not now). Thank you!