Skip to content

Reconcile rules for predicate_id #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 19, 2022
Merged

Reconcile rules for predicate_id #302

merged 13 commits into from
Aug 19, 2022

Conversation

@hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Aug 8, 2022 •
edited
Loading

Fixes #300

  • Reconcile MSDF with an additional rule: Provided the confidence values are equal, predicate_id follows the following hierarchy:
    # owl:equivalentClass
    # owl:equivalentProperty
    # rdfs:subClassOf
    # rdfs:subPropertyOf
    # owl:sameAs
    # skos:exactMatch
    # skos:closeMatch
    # skos:broadMatch
    # skos:narrowMatch
    # oboInOwl:hasDbXref
    # skos:relatedMatch
    # rdfs:seeAlso

@hrshdhgd hrshdhgd marked this pull request as ready for review August 9, 2022 17:59
@hrshdhgd hrshdhgd requested a review from matentzn August 9, 2022 18:03
@matentzn
Copy link
Collaborator

matentzn commented Aug 10, 2022

@hrshdhgd sorry about that my mind isnt where it should be this week. can we review this together on Monday?

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Aug 10, 2022

Not a problem at all! No hurries.

matentzn
matentzn requested changes Aug 17, 2022
View reviewed changes
matentzn
matentzn reviewed Aug 18, 2022
View reviewed changes
matentzn
matentzn reviewed Aug 18, 2022
View reviewed changes
tests/test_merge.py Outdated
"""Test merging of multiple msdfs."""
merged_msdf = merge_msdf(*self.msdfs)
self.assertEqual(123, len(merged_msdf.df))
self.assertEqual(170, len(merged_msdf.df))
Copy link
Collaborator

@matentzn matentzn Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very big change. Is this expected?

Copy link
Collaborator

@matentzn matentzn Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge_msdf should not reconcile by default.. Is it?

Copy link
Contributor Author

@hrshdhgd hrshdhgd Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reconcile is True by default.

Copy link
Collaborator

@matentzn matentzn Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it should not be, can we make it false? during a simple merge, no information should be lost. Make sure that all the API methods are also not set to TRUE by default..

Copy link
Contributor Author

@hrshdhgd hrshdhgd Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, test numbers will change for test_reconcile and test_merge.

matentzn
matentzn approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@hrshdhgd hrshdhgd merged commit 5490672 into master Aug 19, 2022
@hrshdhgd hrshdhgd deleted the more-reconcile branch August 19, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matentzn matentzn matentzn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parse embedded mode: flag true and default true makes no sense Reconciliation rule: using predicate_id

3 participants

@hrshdhgd @matentzn