-
Notifications
You must be signed in to change notification settings - Fork 14
Fixes #305 and #306 #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Fixes #305 and #306 #308
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e1cc2cf
Fixes validate #306
hrshdhgd 07d4bee
fix for #305
hrshdhgd 6fd501f
blank values for prefixes shouls not be added.
hrshdhgd aae6e7e
undo refactor and change logic
hrshdhgd 4b8c70e
changed metadata check logic
hrshdhgd a5bea43
changed logic to get pref from meta
hrshdhgd 9eed253
formatted
hrshdhgd 2722845
casting issue
hrshdhgd d40e075
mypy fix
hrshdhgd f638d7c
mypy fix
hrshdhgd b203ed3
edits after discussion with Nico on PR
hrshdhgd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.