fix(PeerGroup): ignore connections that come in after disconnect() is called

mappum · mappum · commit 4cb9a1241751 · 2016-01-04T18:37:38.000-08:00
Fixes errors when a Node is created then immediately closed (e.g. in the tests).
diff --git a/lib/peerGroup.js b/lib/peerGroup.js
@@ -241,6 +241,7 @@ PeerGroup.prototype._connectToTCPPeers = function (cb) {
 }
 
 PeerGroup.prototype._onTCPPeerConnect = function (peer) {
+  if (this.disconnecting) return
   peer.getTip = this.getTip
   this._onPeerConnect(new Peer(peer))
 }
@@ -262,6 +263,7 @@ PeerGroup.prototype._connectToWebPeers = function () {
 }
 
 PeerGroup.prototype._onWebPeerConnect = function (conn, incoming) {
+  if (this.disconnecting) return
   var peer = new WebPeer(conn, { incoming: !!incoming, getTip: this.getTip })
   peer.connect()
   this._onPeerConnect(peer)

Original file line number	Diff line number	Diff line change
`@@ -241,6 +241,7 @@ PeerGroup.prototype._connectToTCPPeers = function (cb) {`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`PeerGroup.prototype._onTCPPeerConnect = function (peer) {`
	`244`	`+ if (this.disconnecting) return`
`244`	`245`	`peer.getTip = this.getTip`
`245`	`246`	`this._onPeerConnect(new Peer(peer))`
`246`	`247`	`}`
`@@ -262,6 +263,7 @@ PeerGroup.prototype._connectToWebPeers = function () {`
`262`	`263`	`}`
`263`	`264`
`264`	`265`	`PeerGroup.prototype._onWebPeerConnect = function (conn, incoming) {`
	`266`	`+ if (this.disconnecting) return`
`265`	`267`	`var peer = new WebPeer(conn, { incoming: !!incoming, getTip: this.getTip })`
`266`	`268`	`peer.connect()`
`267`	`269`	`this._onPeerConnect(peer)`