Tasking manager geometries #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Matthias-Schaub, |
Matthias-Schaub
approved these changes
May 5, 2020
| project.calc_required_results() | ||
| # Save project and its groups and tasks to Firebase and Postgres. | ||
| project.save_project() | ||
| project.save_project |
There was a problem hiding this comment.
Probably a typo: save_project is a function and should therefor be called with parenthesis ()
| print(len(data)) | ||
|
|
||
| # save as geojson one by one | ||
| for i, project in enumerate(data): |
There was a problem hiding this comment.
Variable i is never used. Maybe for project in data: is enough?
| try: | ||
| geometries = [ogr.CreateGeometryFromWkt(wkt_geom)] | ||
| geojson_functions.create_geojson_file(geometries, outfile) | ||
| except Exception as e: |
There was a problem hiding this comment.
e is never used: except Exception is enough.
pass is not needed in the exception. Only if nothing (no printing for example)/ no statement is in the exception clause then pass can be used.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #333
Further it fixes a small bug in setting up the logger.
@Matthias-Schaub could you review this in the coming days?