Skip to content

Conversation

Hagellach37
Copy link
Member

Hey @laurentS ,
this should basically give you an overview what has changed in regard to the tutorial. All the data is still in firebase.

I basically renamed some of the attributes of the tutorial to allow for a simper set up. You can find a tutorial in the dev firebase here: v2/projects/built_area_tutorial_solid_waste

There is now also a web site to upload tutorial data. (this is not super important for now...)

@Hagellach37 Hagellach37 changed the base branch from master to dev August 20, 2020 16:34
@@ -0,0 +1,98 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurentS this basically tells you for each screen the text strings. these are already in firebase as well. for simplicity it might be the best, if you change in firebase directly if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make it easier (at least on the app side) if the screens were 0-indexed, because with this format firebase returns an array of screens with the first element being null, which is a bit weird.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another tiny bug: xMax in the group was 117, when the tasks actually stop at 115. I've fixed in firebase, but you might want to check if there's a bug in the code that generated the data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to think about how we're going to transition from the old tutorial format to the new one: the "old" app and the "new" one won't be able to use the same tutorial content, so there's probably going to be a period where either the old or the new version is broken for the tutorial. I can't think of a good way to handle this right now, unless maybe by creating a tutorial that has both the "categories" and "screens" in it, which we'd keep until the old version of the app is not around anymore (and we show an announcement asking users to update?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to make sure to set the status correctly, status should be as tutorial name.

@Hagellach37
Copy link
Member Author

@laurentS if you could do a last rough check here, this would be super great. I will merge into dev then to test things on the server.

Copy link
Member

@laurentS laurentS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a bunch of comments and questions. No showstoppers, so I think you can merge right away if you don't want to wait :)

@Hagellach37 Hagellach37 merged commit 0aab6d5 into dev Sep 10, 2020
laurentS added a commit to mapswipe/mapswipe that referenced this pull request Sep 11, 2020
@Hagellach37 Hagellach37 deleted the tutorial-new-structure branch March 3, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants