Correct the s3 tile key path #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 looks good to me! |
Member
Author
|
I added a / prefix to the key name. It shouldn't affect anything, and the other store implementations don't call the |
Member
|
Yup, still looks good. |
rmarianski
added a commit
that referenced
this pull request
Jan 26, 2016
Correct the s3 tile key path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the extra slash from the s3 path. I don't think that this would make any difference, because it seems like the objects were still being saved in the correct location regardless. But this change probably makes sense to make anyway.
@zerebubuth could you review please?