Fixed _isDisabledButtonLeft #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously _isDisabledButtonLeft was checking whether the right button was disabled, not the left one, so when the right button was set as disabled, both would be.
Contributor
Author
|
Could you please update the version number? I didn't do it because I thought you would before merge |
Owner
Already done. Anyway thank you for your pull request I didn't saw that error :) |
Contributor
Author
|
I'm not quite sure why, but I'm having trouble getting the version of this lib with this fix, I've changed the version on my package.json to "^1.2.9" and it still shows up without this correction. My guess would be that this happened because the tree for the commit in which you updated the version number, still shows the index.js file without the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously _isDisabledButtonLeft was checking whether the right button was disabled, not the left one, so when the right button was set as disabled, both would be.