This repository was archived by the owner on Feb 28, 2024. It is now read-only.
Handle wsrep_gtid_mode enabled
#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the parsing logic of the seqno field in the Galera state file - Added a struct to serialize/deserialize the GTID tied to the sequence number - Updated the unit tests
matthieugusmini
force-pushed
the
handle-wsrep-gtid-mode
branch
from
0324405 to
3997fea
Compare
mmontes11
suggested changes
Nov 10, 2023
Member
mmontes11
left a comment
mmontes11
left a comment
There was a problem hiding this comment.
Thanks for the effort investigating this bug and the implementation of the fix 💯
Tests are failing, left a suggestion which might probably fix it
mmontes11
approved these changes
Nov 13, 2023
Member
mmontes11
left a comment
mmontes11
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution 🙏🏻
I will release a v0.0.4-beta1 to test it together with the operator. Would you mind bumping the agent to this version in the mariadb-operator version and raise a PR?
matthieugusmini
pushed a commit
to matthieugusmini/mariadb-operator
that referenced
this pull request
Nov 14, 2023
Upgraded the agent version to v0.0.4-beta1. See mariadb-operator/agent#5 (review)
matthieugusmini
pushed a commit
to matthieugusmini/mariadb-operator
that referenced
this pull request
Nov 14, 2023
Upgraded the agent version to v0.0.4-beta1. See mariadb-operator/agent#5 (review)
matthieugusmini
pushed a commit
to matthieugusmini/mariadb-operator
that referenced
this pull request
Nov 15, 2023
Upgraded the agent version to v0.0.4-beta1. See mariadb-operator/agent#5 (review)
matthieugusmini
pushed a commit
to matthieugusmini/mariadb-operator
that referenced
this pull request
Nov 15, 2023
Upgraded the agent version to v0.0.4-beta1. See mariadb-operator/agent#5 (review)
matthieugusmini
pushed a commit
to matthieugusmini/mariadb-operator
that referenced
this pull request
Nov 20, 2023
Upgraded the agent version to v0.0.4-beta2. See mariadb-operator/agent#5 (review)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant documentation: