style(build): removed redundant code, minor styling updates

Author: mariuszm

gulpfile.js

@@ -38,7 +38,12 @@ var processWinPath = function (file) {
 
 // Compile SASS
 gulp.task('styles:sass', function () {
-    var files = [config.app + '/+(sass|app|common)/**/*.scss', '!' + config.app + '/sass/includes/*.scss', '!' + config.app + '/+(app|common)/**/_*.scss'];
+    var files = [
+        config.app + '/+(sass|app|common)/**/*.scss',
+        '!' + config.app + '/sass/includes/*.scss',
+        '!' + config.app + '/+(app|common)/**/_*.scss'
+    ];
+
     return gulp.src(files, { read: false })
         .on('data', processWinPath)
         .pipe(plugins.plumber())
@@ -53,8 +58,8 @@ gulp.task('styles:sass', function () {
         .pipe(plugins.concat('app.scss'))
         .pipe(plugins.sourcemaps.init())
         .pipe(plugins.sass().on('error', plugins.sass.logError))
-        .pipe(plugins.sourcemaps.write())
-        .pipe(plugins.size({ showFiles: true, title: '[CSS]' }))
+        .pipe(plugins.sourcemaps.write({ sourceRoot: '/' + config.app }))
+        .pipe(plugins.size({ showFiles: true, title: '»»»' }))
         .pipe(gulp.dest(config.build + '/assets'))
         .pipe(bs.stream());
 });

karma.conf.default.js

@@ -3,29 +3,24 @@
 var cfg = require('./config.json');
 
 module.exports = function (config) {
-    config.set({
-        files: [
-            // bower:js
-            // endbower
-            'node_modules/ng-describe/dist/ng-describe.js',
-            cfg.app + '/+(app|common)/**/*.module.js',
-            cfg.app + '/+(app|common)/**/!(*.spec).js',
-            cfg.build + '/assets/' + cfg.templateFile,
-            cfg.paths.tests
-        ],
-        frameworks: ['jasmine'],
-        plugins: ['karma-jasmine', 'karma-phantomjs-launcher', 'karma-coverage'],
+    var options = {
+        frameworks: [ 'jasmine' ],
+        plugins:    [ 'karma-jasmine', 'karma-phantomjs-launcher', 'karma-coverage' ],
+        browsers:   [ 'PhantomJS' ],
+        coverageReporter: { type: 'text' },
+        preprocessors:    {}
+    };
 
-        preprocessors: {
-            'src/+(app|common)/**/!(*.spec).js': 'coverage'
-        },
+    options.preprocessors[ cfg.app + '/+(app|common)/**/!(*.spec).js' ] = 'coverage';
+    options.files = [
+        // bower:js
+        // endbower
+        'node_modules/ng-describe/dist/ng-describe.js',
+        cfg.app + '/+(app|common)/**/*.module.js',
+        cfg.app + '/+(app|common)/**/!(*.spec).js',
+        cfg.build + '/assets/' + cfg.templateFile,
+        cfg.paths.tests
+    ];
 
-        coverageReporter: {
-            type: 'text'
-        },
-
-        browsers: [
-            'PhantomJS'
-        ]
-    });
+    config.set(options);
 };

src/app/about/about.config.js

@@ -4,9 +4,9 @@ angular.module('ngDevstack.about')
 
 .config(function ($stateProvider) {
     $stateProvider.state('about', {
-        url: '/about/',
+        url: '/about',
         views: {
-            "main": {
+            'main': {
                 controller: 'AboutCtrl',
                 templateUrl: 'about/about.tpl.html'
             }

src/app/app.config.js

@@ -5,6 +5,7 @@ angular.module('ngDevstack')
 .config(function ($urlRouterProvider) {
 
     $urlRouterProvider.otherwise('/');
+
     // Please enable mod rewrite in server.js when html5Mode is enabled.
     // Don't forget to inject $locationProvider.
     // Depending on your project requirements, you may further want to
@@ -16,12 +17,11 @@ angular.module('ngDevstack')
 
 
     /*
-    Make a trailing slash optional for all routes
-     */
+    // Make a trailing slash optional for all routes
     $urlRouterProvider.rule(function ($injector, $location) {
         var path = $location.path(),
             search = $location.search(),
-            params;
+            params = [];
 
         if (path[path.length - 1] === '/') {
             return;
@@ -31,11 +31,11 @@ angular.module('ngDevstack')
             return path + '/';
         }
 
-        params = [];
         angular.forEach(search, function (v, k) {
             params.push(k + '=' + v);
         });
 
         return path + '/?' + params.join('&');
     });
+    */
 });

src/app/app.controller.js

@@ -7,7 +7,7 @@ angular.module('ngDevstack')
     // handling UI Bootstrap Collapse plugin
     $scope.isCollapsed = true;
 
-    $rootScope.$on('$stateChangeSuccess', function (event, toState, toParams, fromState, fromParams) {
+    $rootScope.$on('$stateChangeSuccess', function (event, toState) {
         if (angular.isDefined(toState.data.pageTitle)) {
             $scope.pageTitle = toState.data.pageTitle + ' | ng-devstack';
         }

src/app/home/home.config.js

@@ -6,7 +6,7 @@ angular.module('ngDevstack.home')
     $stateProvider.state('home', {
         url: '/',
         views: {
-            "main": {
+            'main': {
                 controller: 'HomeCtrl',
                 templateUrl: 'home/home.tpl.html'
             }