fix(client): allow interface to be implemented

[jkoelker]

The addition of the unexported sendRequest method prevents external packages from implmenting the MCPClient interface. Since it is only used by the unexported listByPage, create an unexported mcpClient interface, which embeds the exported MCPClient as well as the sendRequest method.

Add build time checking that internal implementations implement the unexported interface.

Summary by CodeRabbit

• Refactor
  • Enhanced backend communication to support more robust request handling.
  • Improved internal operations while maintaining the current user experience and preparing for future enhancements.

[coderabbitai]

Walkthrough

The pull request adds a new interface called mcpClient that embeds the existing MCPClient interface and introduces a new sendRequest method. Additionally, the parameter type in the listByPage function is updated from MCPClient to mcpClient, ensuring compatibility with the expanded interface. The overall logic of the function remains unchanged.

Changes

File	Change Summary
client/client.go	Introduced a new mcpClient interface extending MCPClient with the sendRequest method; updated the listByPage function parameter to mcpClient.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7390fe and 5774b4c.

📒 Files selected for processing (1)

• client/client.go (1 hunks)

🔇 Additional comments (3)

client/client.go (3)

113-117: Well implemented interface separation for public and internal use.

The new mcpClient interface effectively solves the problem described in the PR objectives. By embedding the exported MCPClient interface and adding the unexported sendRequest method, you've created a clean separation between what external packages need to implement (just MCPClient) and what internal implementations need to implement (the full mcpClient interface with sendRequest).

This is a good example of using Go's interface embedding to create a hierarchy of capabilities while maintaining a clean public API.

---

121-121: Parameter type change is appropriate and maintains encapsulation.

Changing the parameter type from MCPClient to mcpClient ensures that the listByPage function can access the sendRequest method it needs, while keeping the implementation details hidden from external users.

This follows Go's principle of accepting interfaces but returning concrete types, and properly restricts the function to be used only with implementations that can actually handle all its requirements.

---

111-122: Consider adding build-time checks for interface compliance.

The PR objectives mentioned implementing build-time checks to ensure internal implementations conform to the unexported interface. While the interface structure is correct, I don't see explicit build-time checks in this file.

You might want to add type assertions in a test file to verify compliance:

var _ mcpClient = (*YourConcreteType)(nil)

This would fail at compile time if an implementation doesn't satisfy the interface.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.