Replace remaining invocations of XMLOutputFactory::newInsatnce with XmlFactories::getOutputFactory

Author: Robert Sauer

src/main/java/com/marklogic/client/impl/CombinedQueryBuilderImpl.java

@@ -239,8 +239,7 @@ private String makeJSONCombinedQuery(CombinedQueryDefinitionImpl qdef) {
     }
 
     private XMLStreamWriter makeXMLSerializer(OutputStream out) {
-        XMLOutputFactory factory = XMLOutputFactory.newInstance();
-        factory.setProperty(XMLOutputFactory.IS_REPAIRING_NAMESPACES, true);
+        XMLOutputFactory factory = XmlFactories.getOutputFactory();
 
         try {
             XMLStreamWriter serializer = factory.createXMLStreamWriter(out, "UTF-8");

src/main/java/com/marklogic/client/impl/DocumentMetadataPatchBuilderImpl.java

@@ -1053,8 +1053,7 @@ public PatchHandle build() throws MarkLogicIOException {
 		} else {
 			handle.setFormat(Format.XML);
 			try {
-				XMLOutputFactory factory = XMLOutputFactory.newInstance();
-				factory.setProperty("javax.xml.stream.isRepairingNamespaces", true);
+				XMLOutputFactory factory = XmlFactories.getOutputFactory();
 
 				StringWriter    writer     = new StringWriter();
 				XMLStreamWriter serializer = factory.createXMLStreamWriter(writer);

src/main/java/com/marklogic/client/io/DocumentMetadataHandle.java

@@ -56,6 +56,7 @@
 import com.marklogic.client.impl.ClientPropertiesImpl;
 import com.marklogic.client.impl.DOMWriter;
 import com.marklogic.client.impl.ValueConverter;
+import com.marklogic.client.impl.XmlFactories;
 import com.marklogic.client.io.marker.BufferableHandle;
 import com.marklogic.client.io.marker.DocumentMetadataReadHandle;
 import com.marklogic.client.io.marker.DocumentMetadataWriteHandle;
@@ -656,8 +657,7 @@ private void receiveQualityImpl(Document document) {
 	// TODO: select the metadata sent
 	private void sendMetadataImpl(OutputStream out) {
 		try {
-			XMLOutputFactory factory = XMLOutputFactory.newInstance();
-			factory.setProperty("javax.xml.stream.isRepairingNamespaces", true);
+			XMLOutputFactory factory = XmlFactories.getOutputFactory();
 
 			valueSerializer = null;
 

src/main/java/com/marklogic/client/query/StructuredQueryBuilder.java

@@ -40,6 +40,7 @@
 import com.marklogic.client.MarkLogicIOException;
 import com.marklogic.client.impl.AbstractQueryDefinition;
 import com.marklogic.client.impl.RawQueryDefinitionImpl;
+import com.marklogic.client.impl.XmlFactories;
 import com.marklogic.client.io.BaseHandle;
 import com.marklogic.client.io.Format;
 import com.marklogic.client.io.OutputStreamSender;
@@ -2416,8 +2417,7 @@ private void checkRegion(Region region) {
     }
 
     static private XMLStreamWriter makeSerializer(OutputStream out) {
-		XMLOutputFactory factory = XMLOutputFactory.newInstance();
-		factory.setProperty(XMLOutputFactory.IS_REPAIRING_NAMESPACES, true);
+		XMLOutputFactory factory = XmlFactories.getOutputFactory();
 
 		try {
 			XMLStreamWriter serializer = factory.createXMLStreamWriter(out, "UTF-8");

src/test/java/com/marklogic/client/test/CombinedQueryBuilderTest.java

@@ -33,6 +33,7 @@
 
 import com.marklogic.client.impl.CombinedQueryBuilderImpl;
 import com.marklogic.client.impl.CombinedQueryDefinition;
+import com.marklogic.client.impl.XmlFactories;
 import com.marklogic.client.io.Format;
 import com.marklogic.client.io.StringHandle;
 import com.marklogic.client.io.marker.QueryOptionsWriteHandle;
@@ -124,8 +125,7 @@ public void writeOptions(XMLStreamWriter writer) throws XMLStreamException {
     }
 
     public XMLStreamWriter makeXMLStreamWriter(OutputStream out) throws XMLStreamException {
-        XMLOutputFactory factory = XMLOutputFactory.newInstance();
-        factory.setProperty(XMLOutputFactory.IS_REPAIRING_NAMESPACES, true);
+        XMLOutputFactory factory = XmlFactories.getOutputFactory();
 
         XMLStreamWriter writer = factory.createXMLStreamWriter(out, "UTF-8");
         writer.setDefaultNamespace("http://marklogic.com/appservices/search");