NPE in repository.read(ID id)

[grechaw]

If you read from a repository, since yesterady,

City c = cities.read(3);

and that ID does not exist in the database, here is the result:

java.lang.NullPointerException
    at com.marklogic.client.impl.JerseyServices.getBulkDocumentsImpl(JerseyServices.java:834)
    at com.marklogic.client.impl.JerseyServices.getBulkDocuments(JerseyServices.java:730)
    at com.marklogic.client.impl.DocumentManagerImpl.read(DocumentManagerImpl.java:398)
    at com.marklogic.client.impl.JSONDocumentImpl.read(JSONDocumentImpl.java:1)
    at com.marklogic.client.impl.DocumentManagerImpl.read(DocumentManagerImpl.java:370)
    at com.marklogic.client.impl.JSONDocumentImpl.read(JSONDocumentImpl.java:1)
    at com.marklogic.client.impl.DocumentManagerImpl.read(DocumentManagerImpl.java:359)
    at com.marklogic.client.impl.JSONDocumentImpl.read(JSONDocumentImpl.java:1)
    at com.marklogic.client.impl.PojoRepositoryImpl.read(PojoRepositoryImpl.java:279)
    at com.marklogic.client.impl.PojoRepositoryImpl.read(PojoRepositoryImpl.java:264)
    at com.marklogic.client.impl.PojoRepositoryImpl.read(PojoRepositoryImpl.java:257)
    at com.marklogic.client.test.PojoFacadeTest.testB_ReadPojos(PojoFacadeTest.java:205)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)

This should just return a null.

I'm marking as critical because a PR in samplestack is not operable because of this unexpected change.

[sammefford]

Sravan, if you feel it's desirable, you could add to your regression tests some negative tests like i added to this commit. Also, please notice that I'm realizing and making explicit that most methods in the PojoRepository will throw ForbiddenUserException, and FailedRequestException and read methods will throw ResourceNotFoundException.