Improved test for HTTP chunking #1477
Merged
+86
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillFarber
approved these changes
Dec 7, 2022
rjrudin
force-pushed
the
feature/compression-chunking-test
branch
from
a19cfd9 to
49d5059
Compare
rjrudin
force-pushed
the
feature/compression-chunking-test
branch
from
49d5059 to
4c73839
Compare
rjrudin
force-pushed
the
feature/compression-chunking-test
branch
9 times, most recently
from
8fc13a8 to
5260bcb
Compare
Also fixed a bug in the error handling where a `FailedRequest` was constructed and populated, but it was not actually passed into the `FailedRequestException`, thereby causing a null-pointer error when certain parts of the `FailedRequestException` were added.
rjrudin
force-pushed
the
feature/compression-chunking-test
branch
from
b88b7bc to
fb6f669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a bug in the error handling where a
FailedRequestwas constructed and populated, but it was not actually passed into theFailedRequestException, thereby causing a null-pointer error when certain parts of theFailedRequestExceptionwere added.