Fixing stop-transform job tests #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause was that they were ignoring URIs that intermittently failed due to the InterruptedException. These URIs were being set to the failure handler, so they weren't being dropped. The tests just needed to account for them. Also made both of these extends AbstractFunctionalTest so that they run a lot faster now. Fixed a typo in Jenkinsfile too.
rjrudin
commented
Dec 8, 2022
|
|
||
| assertEquals( | ||
| "Unexpected count; success: " + successCount + "; skipped: " + skippedCount + "; failed: " + failedCount, | ||
| DOC_COUNT, successCount + skippedCount + failedCount + notTransformedCount.get()); |
Contributor
Author
There was a problem hiding this comment.
@anu3990 This is the key change here (the rest was just tidying up) - the test now accounts for URIs that failed due to the InterruptedException.
| assertTrue("Number of docs transformed must be <= number of docs selected; " + | ||
| "applied count: " + appliedTranscount.get() + "; success batch size: " + successBatch.size(), | ||
| appliedTranscount.get() <= successBatch.size()); | ||
| "applied count: " + transformedCount.get() + "; success batch size: " + successUris.size() + "; failed count: " + failedUris.size(), |
Contributor
Author
There was a problem hiding this comment.
Same change here, failed URIs are accounted for now.
BillFarber
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause was that they were ignoring URIs that intermittently failed due to the InterruptedException. These URIs were being set to the failure handler, so they weren't being dropped. The tests just needed to account for them.
Also made both of these extends AbstractFunctionalTest so that they run a lot faster now.
Fixed a typo in Jenkinsfile too.