Forcing port to 443 when using MarkLogic cloud authentication #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
commented
Jan 23, 2023
|
|
||
| static OkHttpClient.Builder newOkHttpClientBuilder(String host, int port, DatabaseClientFactory.SecurityContext securityContext) { | ||
| return OkHttpUtil.newOkHttpClientBuilder(host, port, securityContext); | ||
| static OkHttpClient.Builder newOkHttpClientBuilder(String host, DatabaseClientFactory.SecurityContext securityContext) { |
Contributor
Author
There was a problem hiding this comment.
This is what ml-app-deployer users - it becomes simpler because the ML cloud auth configurer can safely assume usage of 443 for obtaining an access token, so "port" doesn't need to be provided anymore.
rjrudin
commented
Jan 23, 2023
| "When the port is 443, OkHttp won't include it in the URL"); | ||
| } | ||
|
|
||
| @Test |
Contributor
Author
There was a problem hiding this comment.
This test reflects a now-invalid scenario and has thus been removed.
Contributor
Author
|
@anu3990 This is likely worth doing in the Node Client as well. |
BillFarber
approved these changes
Jan 24, 2023
443 is written in stone for now, and thus the UX can be simpler by forcing the port to that value. Also, removed support for defaulting to 443 in DatabaseClientPropertySource. That was intended for ML Cloud users, but the better way to do it is via the DatabaseClientFactory method that's modified in this PR.
rjrudin
force-pushed
the
feature/default-443
branch
from
fe450cd to
6cec368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
443 is written in stone for now, and thus the UX can be simpler by forcing the port to that value.