ml-development-tools now uses test-app #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got rid of the custom code for setting up / tearing down databases and app servers. Changed the test code to use port 8013, as java-client-api is already using 8012 and 8014. Updated gitignore as well so you can run the tests and not have 1400+ changes sitting in your branch. The 3 Java files that were updated are all test files and were updated when I ran `generateTests`.
BillFarber
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of the custom code for setting up / tearing down databases and app servers. Changed the test code to use port 8013, as java-client-api is already using 8012 and 8014.
Updated gitignore as well so you can run the tests and not have 1400+ changes sitting in your branch.
The 3 Java files that were updated are all test files and were updated when I ran
generateTests.