Can now use search options in ML12 for BM25, Zero, and Random. #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
requested changes
Jul 8, 2024
marklogic-client-api/src/main/java/com/marklogic/client/type/PlanSearchOptions.java
Outdated
Show resolved
Hide resolved
marklogic-client-api/src/test/java/com/marklogic/client/impl/OpticPlanSearchOptionsTest.java
Outdated
Show resolved
Hide resolved
marklogic-client-api/src/test/java/com/marklogic/client/impl/OpticPlanSearchOptionsTest.java
Outdated
Show resolved
Hide resolved
marklogic-client-api/src/test/java/com/marklogic/client/impl/OpticPlanSearchOptionsTest.java
Outdated
Show resolved
Hide resolved
BillFarber
force-pushed
the
task/addNewSearchOptions
branch
2 times, most recently
from
084242e to
9310a96
Compare
rjrudin
previously approved these changes
Jul 8, 2024
Contributor
rjrudin
left a comment
rjrudin
left a comment
There was a problem hiding this comment.
Approved, but see if it's possible to make a test that fails on an invalid BM25 length weight.
...logic-client-api/src/test/java/com/marklogic/client/test/rows/FromSearchWithOptionsTest.java
Show resolved
Hide resolved
BillFarber
force-pushed
the
task/addNewSearchOptions
branch
from
9310a96 to
9d7dddf
Compare
rjrudin
previously approved these changes
Jul 8, 2024
...logic-client-api/src/test/java/com/marklogic/client/test/rows/FromSearchWithOptionsTest.java
Outdated
Show resolved
Hide resolved
BillFarber
force-pushed
the
task/addNewSearchOptions
branch
from
9d7dddf to
907bf43
Compare
rjrudin
previously approved these changes
Jul 8, 2024
Contributor
rjrudin
left a comment
rjrudin
left a comment
There was a problem hiding this comment.
LG, just a few bookkeeping javadocs to add.
marklogic-client-api/src/main/java/com/marklogic/client/type/PlanSearchOptions.java
Show resolved
Hide resolved
marklogic-client-api/src/main/java/com/marklogic/client/type/PlanSearchOptions.java
Show resolved
Hide resolved
Also adds a setting for BM25 Length Weight. Added a couple of tests. These tests are of limited use here, but they do verify that "bm25" and "zero" are acceptable scoring options. They also verify the exception when bm25lengthweight is out of bounds. docs
BillFarber
force-pushed
the
task/addNewSearchOptions
branch
from
907bf43 to
183b016
Compare
rjrudin
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a setting for BM25 Length Weight.
Added a couple of tests. These tests are of limited use here, but they do verify that "bm25" and "zero" are acceptable scoring options.