Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 15, 2025

Removed hack in BitemporalTest for bug that is fixed. And bumped mockito, realized it can go to 5 safely now.

Removed hack in BitemporalTest for bug that is fixed. And bumped mockito, realized it can go to 5 safely now.
@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 19:00
@github-actions
Copy link

Copyright Validation Results
Total: 4 | Passed: 1 | Failed: 0 | Skipped: 3 | at: 2025-10-15 19:00:36 UTC | commit: 1bfc536

⏭️ Skipped (Excluded) Files

  • marklogic-client-api-functionaltests/build.gradle
  • marklogic-client-api/build.gradle
  • test-app/build.gradle

✅ Valid Files

  • marklogic-client-api/src/test/java/com/marklogic/client/test/BitemporalTest.java

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ml-gradle plugin from version 6.0.1 to 6.1.0, which fixes a bug related to LSQT properties deployment. The update allows removal of a workaround in BitemporalTest and enables upgrading test dependencies including Mockito (4.x to 5.x) and JUnit Platform (1.13.4 to 1.14.0).

Key changes:

  • Upgraded ml-gradle plugin to 6.1.0, fixing MLE-24511 bug
  • Removed manual LSQT deployment workaround from BitemporalTest
  • Updated test dependencies: Mockito to 5.20.0, JUnit to 5.14.0, and other minor version bumps

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
test-app/build.gradle Updated ml-gradle plugin version from 6.0.1 to 6.1.0
marklogic-client-api/src/test/java/com/marklogic/client/test/BitemporalTest.java Removed workaround code and unused imports for manual LSQT deployment
marklogic-client-api/build.gradle Updated test dependencies: ml-app-deployer to 6.1.0, Mockito to 5.20.0, mockwebserver3 to 5.2.0, junit-platform-launcher to 1.14.0
marklogic-client-api-functionaltests/build.gradle Updated test dependencies: ml-app-deployer to 6.1.0, junit-jupiter to 5.14.0, junit-platform-launcher to 1.14.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

exclude module: "marklogic-client-api"
}
testImplementation "com.marklogic:ml-app-deployer:6.1.0"

Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment explaining why Mockito 4.x was used (Java 8 support requirement) has been removed, but there's no explanation for why it's now safe to upgrade to 5.x. Consider adding a comment explaining that Java 11+ is now the minimum requirement or that Java 8 support has been dropped.

Suggested change
// Mockito 5.x requires Java 11 or higher; Java 8 support has been dropped.
// It is now safe to use Mockito 5.x as Java 11+ is the minimum supported version for this project.

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin merged commit a398a93 into develop Oct 15, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/bump branch October 15, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants