Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 16, 2025

Bug was fixed in the server.

Bug was fixed in the server.
@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 13:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables a previously disabled test by removing a version check that was bypassing the test for MarkLogic version 12 and above. The test was disabled due to bug MLE-12708, which has now been fixed in the server.

  • Removed conditional skip logic for MarkLogic version 12+ in testPagination() method
  • Changed class visibility from public to package-private

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

import static org.junit.jupiter.api.Assertions.*;

public class SPARQLManagerTest {
class SPARQLManagerTest {
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class visibility change from public to package-private appears unrelated to re-enabling the test. This change should be documented in the PR description or separated into a different commit as it's a distinct modification from the main purpose of fixing MLE-12708.

Suggested change
class SPARQLManagerTest {
public class SPARQLManagerTest {

Copilot uses AI. Check for mistakes.

@github-actions
Copy link

Copyright Validation Results
Total: 1 | Passed: 1 | Failed: 0 | Skipped: 0 | at: 2025-10-16 13:16:02 UTC | commit: b8bd7e4

✅ Valid Files

  • marklogic-client-api/src/test/java/com/marklogic/client/test/SPARQLManagerTest.java

✅ All files have valid copyright headers!

@rjrudin rjrudin merged commit 1775b81 into develop Oct 16, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/12708-fix branch October 16, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants