Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 17, 2025

Not mentioning Confluent Platform versions anymore, so we don't have to be in the business of syncing with those. We just want to mention Kafka versions.

@rjrudin rjrudin requested a review from BillFarber as a code owner October 17, 2025 15:42
@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 15:42
Copy link

github-actions bot commented Oct 17, 2025

Copyright Validation Results
Total: 1 | Passed: 0 | Failed: 0 | Skipped: 1 | at: 2025-10-17 15:45:26 UTC | commit: 3a47c8b

⏭️ Skipped (Excluded) Files

  • docs/system-requirements.md

✅ All files have valid copyright headers!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates system requirements documentation to remove Confluent Platform references and adjust stated Kafka/Java version requirements.

  • Replaces prior Kafka/Confluent bullet with a combined Kafka 4.0+/Java 17+ plus historical 1.x connector requirements.
  • Removes explanatory paragraph about untested earlier Kafka/Confluent versions.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

The MarkLogic Kafka connector has the following system requirements:

* Kafka 2.5 or higher, or Confluent Platform 7 or higher
* Kafka 4.0 or higher, with Java 17 or higher. Releases 1.x of the MarkLogic Kafka connector require Kafka 2.5 or higher, which requires Java 8 or higher.
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line conflates current and historical requirements, making it unclear which connector versions the Kafka 4.0/Java 17 requirement applies to. Recommend splitting into separate bullets (e.g., one for current connector version requirements and one for 1.x) and explicitly naming the connector version(s) to remove ambiguity: '* Connector 2.x requires Kafka or higher and Java 17 or higher.' '* Connector 1.x requires Kafka 2.5 or higher and Java 8 or higher.' Also verify that Kafka 4.0 is the correct minimum if it is officially released/supported; otherwise adjust to the latest supported major/minor.

Suggested change
* Kafka 4.0 or higher, with Java 17 or higher. Releases 1.x of the MarkLogic Kafka connector require Kafka 2.5 or higher, which requires Java 8 or higher.
* MarkLogic Kafka Connector 2.x requires Kafka 3.6 or higher and Java 17 or higher.
* MarkLogic Kafka Connector 1.x requires Kafka 2.5 or higher and Java 8 or higher.

Copilot uses AI. Check for mistakes.

Not mentioning Confluent Platform versions anymore, so we don't have to be in the business of syncing with those. We just want to mention Kafka versions.
@rjrudin rjrudin force-pushed the feature/doc-updates branch from 64d94d0 to 3a47c8b Compare October 17, 2025 15:45
@rjrudin rjrudin merged commit a4d0ae9 into develop Oct 17, 2025
2 of 3 checks passed
@rjrudin rjrudin deleted the feature/doc-updates branch October 17, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants