Merged marklogic-junit library into marklogic-unit-test #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped version to 0.13.develop. Once this is ready for 0.13.0 or 1.0.0, will need to update the references to 0.13.develop. Also made a fix in marklogic-unit-test-client/build.gradle so that createHttpCredentials isn't executed when any task is run, but only when it's run. See the README file in the marklogic-junit directory for more information.
joecrean
reviewed
Apr 3, 2019
| ./gradlew hubInit | ||
|
|
||
| Then add the following lines to gradle.properties: | ||
|
|
There was a problem hiding this comment.
I think it would be a good idea to add a line of doc here just to remind the user that the username below will be used in the test requests and that it and the password needs to be set.. maybe with a hint towards the data-hub-user
joecrean
reviewed
Apr 3, 2019
|
|
||
| ### Configure build.gradle | ||
|
|
||
| First, make sure you're applied the Gradle "java" plugin: |
joecrean
approved these changes
Apr 3, 2019
joecrean
left a comment
joecrean
left a comment
There was a problem hiding this comment.
left a few comments - the two examples run fine. marklogic-junit looks great.
Contributor
|
I went ahead and merged this in for now. I think the DHF examples should probably live inside the DHF project eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is just files copied from rjrudin/marklogic-junit into this project. I did remove support for running DHF harmonization flows as the code was written for DHF 4.0.0, and there were breaking changes with DHF 4.1.0, so that'll be an exercise for another day.
Bumped version to 0.13.develop. Once this is ready for 0.13.0 or 1.0.0, will need to update the references to 0.13.develop.
Also made a fix in marklogic-unit-test-client/build.gradle so that createHttpCredentials isn't executed when any task is run, but only when it's run.
See the README file in the marklogic-junit directory for more information.