-
Notifications
You must be signed in to change notification settings - Fork 80
Created an example of using external security #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Minor updates to fix readability of the README
Updating README for version 3.6.1
examples/external-security/README.md
Outdated
| @@ -0,0 +1,4 @@ | |||
| This project shows how to configure an external security and use it in an app sever. | |||
|
|
|||
| If you want to deploy using a user with external security you'll need to configure the 8000, 8001 and 8002 server added of time. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"added" should be "ahead"?
| @@ -0,0 +1,13 @@ | |||
| plugins { | |||
| // The properties plugin must be applied BEFORE ml-gradle so that ml-gradle sees the results of the properties plugin | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is documented elsewhere and can be removed - I like to slim these example projects down to the bare minimum so it's clear what's being demonstrated.
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you format this file? 2 spaces or a tab, doesn't really matter.
examples/external-security/README.md
Outdated
| @@ -0,0 +1,4 @@ | |||
| This project shows how to configure an external security and use it in an app sever. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sever" -> "server"
| id "com.marklogic.ml-gradle" version "3.6.0" | ||
| } | ||
|
|
||
| task printHost { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this task needed for the purpose of showing how to configure an external security?
| @@ -0,0 +1,8 @@ | |||
| mlHost=dev-host | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to show different environment properties files in action - I think it distracts from the purpose of showing how to configure external security. I think just use "gradle.properties", no need for the different environment files.
| "group-name": "%%GROUP%%", | ||
| "port": "5432", | ||
| "server-name": "example-servers", | ||
| "modules-database": "%%mlModulesDbName%%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "mlModulesDbName" defined somewhere?
| @@ -0,0 +1,9 @@ | |||
| mlHost=localhost | |||
| mlAppName=properties-example | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "external-security-example"?
|
Made requested changes. |
|
Thanks @freshie I will try it out this week. |
I created an issue for this, issue #347. (#347)