Skip to content

Conversation

@freshie
Copy link
Contributor

@freshie freshie commented May 22, 2018

I created an issue for this, issue #347. (#347)

@@ -0,0 +1,4 @@
This project shows how to configure an external security and use it in an app sever.

If you want to deploy using a user with external security you'll need to configure the 8000, 8001 and 8002 server added of time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"added" should be "ahead"?

@@ -0,0 +1,13 @@
plugins {
// The properties plugin must be applied BEFORE ml-gradle so that ml-gradle sees the results of the properties plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is documented elsewhere and can be removed - I like to slim these example projects down to the bare minimum so it's clear what's being demonstrated.

@@ -0,0 +1,16 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format this file? 2 spaces or a tab, doesn't really matter.

@@ -0,0 +1,4 @@
This project shows how to configure an external security and use it in an app sever.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sever" -> "server"

id "com.marklogic.ml-gradle" version "3.6.0"
}

task printHost {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this task needed for the purpose of showing how to configure an external security?

@@ -0,0 +1,8 @@
mlHost=dev-host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to show different environment properties files in action - I think it distracts from the purpose of showing how to configure external security. I think just use "gradle.properties", no need for the different environment files.

"group-name": "%%GROUP%%",
"port": "5432",
"server-name": "example-servers",
"modules-database": "%%mlModulesDbName%%",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "mlModulesDbName" defined somewhere?

@@ -0,0 +1,9 @@
mlHost=localhost
mlAppName=properties-example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "external-security-example"?

@freshie
Copy link
Contributor Author

freshie commented May 23, 2018

Made requested changes.

@rjrudin
Copy link
Contributor

rjrudin commented Jun 7, 2018

Thanks @freshie I will try it out this week.

@rjrudin rjrudin changed the base branch from master to dev June 14, 2018 23:10
@rjrudin rjrudin merged commit 13b0ad5 into marklogic:dev Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants