Updated ssl-2way to work with ml-gradle 4.x #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version used ml-gradle 3.x and Java Client 4. With ml-gradle 4.x using Java Client 5 and higher, an X509TrustManager must be explicitly provided (has to do with the Java Client changing from using Apache HTTP to OkHttp between major versions 4 and 5). Setting `restTrustManager` accomplishes that. Also had to bump up the SSL version to the standard TLSv1.2. This project will receive more updates soon so that it is easier to test with.
BillFarber
reviewed
Aug 14, 2023
| sslContext.init(key, trust, null) | ||
|
|
||
| restSslContext = sslContext | ||
| restTrustManager = trust[0] |
Contributor
There was a problem hiding this comment.
Is it possible for trust to be an empty array?
Contributor
Author
There was a problem hiding this comment.
I believe that would require using a JVM with an empty cacerts file with no trust managers. That seems very unlikely, and given that this is only example code, that's something a user would get a hard error on - which is probably better than failing by not passing in any trust manager at all.
BillFarber
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version used ml-gradle 3.x and Java Client 4. With ml-gradle 4.x using Java Client 5 and higher, an X509TrustManager must be explicitly provided (has to do with the Java Client changing from using Apache HTTP to OkHttp between major versions 4 and 5). Setting
restTrustManageraccomplishes that.Also had to bump up the SSL version to the standard TLSv1.2.
This project will receive more updates soon so that it is easier to test with.