-
Notifications
You must be signed in to change notification settings - Fork 80
Schemas data loading #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@grechaw Sorry for the delay, been swamped, I'll get this merged in and publish 2.1 by the end of this coming weekend. |
|
|
||
| String schemasGroup = "ml-gradle Schemas" | ||
| project.task("mlLoadSchemas", type: LoadSchemasTask, group: schemasGroup, description: "Loads special-purpose data into the schemas database (XSD schemas, Inference rules, and [MarkLogic 9] Extraction Templates)") | ||
| project.task("mlReloadSchemas", type: LoadSchemasTask, dependsOn: ["mlClearSchemasDatabase", "mlLoadSchemas"], group: schemasGroup, description: "Clears schemas database then loads special-purpose data into the schemas database (XSD schemas, Inference rules, and [MarkLogic 9] Extraction Templates)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For mlReloadSchemas, you actually don't want a type - look at mlReloadModules as an example.
Also, the order of tasks in dependsOn doesn't force when Gradle will invoke the tasks. To ensure that mlLoadSchemas always runs after mlClearSchemasDatabase, you do this:
project.task("mlLoadSchemas", type....).mustRunAfter("mlClearSchemasDatabase")
I think mlLoadSchemas has to be defined after mlSchemasDatabase in order for mustRunAfter to work properly.
|
Hi @rjrudin , I've made the updates based on your feedback and added a commit. I was not completely confident -- it seems to work for my needs. Note also an update to ml-javaclient-util PR that I needed to make extaction tempaltes work properly (they need to be in a protected collection) |
|
@rjrudin I'm not confident that the default path property is working for ml-schemas. When you give it a test run please note if I've done something wrong there. It can be a bit of a time suck trying to get all these bits right. |
…t need a list so there's only one
|
I merged it into dev and will test it out with some other changes for 2.1.0 |
…ect, don't need a list so there's only one
This task adds support for loading schemas database to ml-gradle.
Let's see if this new batch of PRs works for you -- I've been having success so far.