Skip to content

fix: reset id counter on cleanup #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2020
Merged

fix: reset id counter on cleanup #5

merged 2 commits into from
Feb 22, 2020

Conversation

mlrawlings
Copy link
Member

Description

Reset's the global id counter when cleanup is called

Motivation and Context

When :scoped values are used, they should be stable.

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@mlrawlings mlrawlings merged commit 335ab49 into master Feb 22, 2020
@mlrawlings mlrawlings mentioned this pull request Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DylanPiercey DylanPiercey DylanPiercey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mlrawlings @DylanPiercey