The cli check for cleanup always matches when --full-static is passed #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an ambiguity in how short and long cli flags are passed that
causes the script to clean whenever a full-static build is attempted
with long cli option `--full-static``.
The second clause of the conditional that checks for the cleanup flag
if [[ "$1" == "--cleanup" || "$1" =~ 'c' ]]; then
is overly broad and evaluates as truthy if $1 is "--full-cleanup". This
can be easily fixed by appending an additional string check against the
string "==", e.g `! "$1" =~ '--'`.
Owner
|
Thanks, merged :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an ambiguity in how short and long cli flags are passed that causes the script to clean whenever a full-static build is attempted with long cli option
--full-static.The second clause of the conditional that checks for the cleanup flag
is overly broad and evaluates as truthy if $1 is "--full-cleanup". This
can be easily fixed by appending an additional string check along the lines of
|| "$1" =~ 'c' && ! "$1" =~ '--'.