Skip to content

Conversation

@caseman
Copy link
Contributor

@caseman caseman commented Jan 16, 2014

There is no variable 'error' defined, so the error case fails. I changed it to throw a new generic Error which fixes the problem.

There is no variable 'error' defined, so the error case fails. I changed it to throw a new generic Error which fixes the problem.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 54423a3 on caseman:patch-1 into 563efcf on markusn:master.

@markusn
Copy link
Owner

markusn commented Jan 16, 2014

Hi!

Thanks for the PR!

Do you have any example input which triggers the throws?

@caseman
Copy link
Contributor Author

caseman commented Jan 16, 2014

Yeah, I triggered it by passing NaNs to closest() accidentally, e.g.:

diff.closest({R:NaN, G:NaN, B:NaN}, [{R:0, G:0, B:0}])

markusn added a commit that referenced this pull request Jan 16, 2014
fix 'ReferenceError: error is not defined'
@markusn markusn merged commit 12dd9c7 into markusn:master Jan 16, 2014
@markusn
Copy link
Owner

markusn commented Jan 16, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants