Skip to content

Conversation

@sanmai
Copy link
Contributor

@sanmai sanmai commented Aug 25, 2020

No description provided.

@martin-helmich
Copy link
Owner

Thanks for this PR! Unfortunately, after enabling the actual pipelines for this PR, I've noticed that currently Composer is not able to resolve a compatible set of dependencies for this project for PHP 8 -- mainly because there's no PHP 8-compatible version of phpspec/prophecy (already tracked at phpspec/prophecy#491). So there's no way the new CI jobs would pass with PHP 8.

I'll sit on this for a while -- hopefully, this'll resolve itself in the next few days.

Oh, and we'd also need to exclude the "PHP 8"+"PHPUnit 8" combination from the build matrix, since PHPUnit 8 is declared to be compatible with PHP ^7.2, only.

@sanmai
Copy link
Contributor Author

sanmai commented Aug 26, 2020

Thanks for the review! I made it such so failures on 8.0 would not affect the entire build. This should work, but let me try with something else too.

@sanmai
Copy link
Contributor Author

sanmai commented Aug 26, 2020

Alright, it is as good as it gets. Hope you can squash-merge it.

I added a pretty name for the builds, you might want to update your protected branch configuration. Or we can restore the old naming scheme.

@sanmai sanmai requested a review from martin-helmich August 26, 2020 00:57
@martin-helmich martin-helmich merged commit d98cd4e into martin-helmich:master Aug 26, 2020
@martin-helmich
Copy link
Owner

👍 Looking good! Thanks for your contribution.

@sanmai sanmai deleted the patch-1 branch August 26, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants