Skip to content

Update JsonValueMatches.php #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2020
Merged

Update JsonValueMatches.php #28

merged 1 commit into from
Oct 18, 2020

Conversation

@SoftCreatR
Copy link
Contributor

@SoftCreatR SoftCreatR commented Oct 18, 2020 •
edited
Loading

JSONPath::data is deprecated in favor of JSONPath::getData and will be removed in 0.7.0.

@SoftCreatR
Update JsonValueMatches.php
3b48977 
`JSONPath::data` is deprecated in favor of `JSONPath::getData`
martin-helmich
martin-helmich approved these changes Oct 18, 2020
View reviewed changes
Copy link
Owner

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I could get used to library authors patching their own libraries in other people's repositories... 😉

Seriously though, thanks for the PR (and also in general for giving the jsonpath library a new home). 😄👍

@martin-helmich martin-helmich merged commit f42c632 into martin-helmich:master Oct 18, 2020
@SoftCreatR SoftCreatR deleted the patch-1 branch October 18, 2020 22:36
@SoftCreatR
Copy link
Contributor Author

You're welcome. As soon, as you push a new tag/release, I'll release 0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-helmich martin-helmich martin-helmich approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SoftCreatR @martin-helmich