Skip to content

[Bug Fix] Fix buffer overflow as a result of overflowed assert #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gafferongames merged 2 commits into from
Nov 19, 2025
Merged

[Bug Fix] Fix buffer overflow as a result of overflowed assert #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c0a21b
fix overflow problems
jparr721 Nov 17, 2025
588ee75
fix the build
jparr721 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions serialize.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ namespace serialize
void WriteBytes( const uint8_t * serialize_restrict data, int bytes )
{
serialize_assert( GetAlignBits() == 0 );
serialize_assert( m_bitsWritten + bytes * 8 <= m_numBits );
serialize_assert( uint64_t(m_bitsWritten) + uint64_t(bytes) * 8 <= uint64_t(m_numBits) );
serialize_assert( ( m_bitsWritten % 32 ) == 0 || ( m_bitsWritten % 32 ) == 8 || ( m_bitsWritten % 32 ) == 16 || ( m_bitsWritten % 32 ) == 24 );

int headBytes = ( 4 - ( m_bitsWritten % 32 ) / 8 ) % 4;
Expand Down Expand Up @@ -715,7 +715,7 @@ namespace serialize
void ReadBytes( uint8_t * serialize_restrict data, int bytes )
{
serialize_assert( GetAlignBits() == 0 );
serialize_assert( m_bitsRead + bytes * 8 <= m_numBits );
serialize_assert( uint64_t(m_bitsRead) + uint64_t(bytes) * 8 <= uint64_t(m_numBits) );
serialize_assert( ( m_bitsRead % 32 ) == 0 || ( m_bitsRead % 32 ) == 8 || ( m_bitsRead % 32 ) == 16 || ( m_bitsRead % 32 ) == 24 );

int headBytes = ( 4 - ( m_bitsRead % 32 ) / 8 ) % 4;
Expand Down