Skip to content

Conversation

elpoutro
Copy link

I want support for symfony/process ^7.0 to be able to use php-ansible on Symfony7.0.

I have tested with PHP8.1, 8.2, and 8.3:

  1. with PHP8.1:

composer update set symfony/process to v.6.4.7
phpunit stay OK (73 tests, 140 assertions)

  1. with PHP8.2:

composer update set symfony/process to v.7.0.7
phpunit stay OK (73 tests, 140 assertions)

  1. with PHP8.3:

composer update set symfony/process to v.7.0.7
I get this error:

1) Asm\Ansible\Command\AnsibleGalaxyTest::testExecute
Symfony\Component\Process\Exception\RuntimeException: Unable to launch a new process.

But i get the same error with current php-ansible version (how use symfony/process to v.6.4.7). So i think we can path through the php 8.3 compatibility for this merge request?

Not that i try to fix quickly the php8.3 issue but i didn't understood the problem. I wonder if i miss a php8.3-* package on my system... Is anybody can make the same test to check this possibility?

@elpoutro
Copy link
Author

I m closing because #93 do it better than i suggested.

@elpoutro elpoutro closed this May 27, 2024
@elpoutro elpoutro deleted the addSupportSyfmony7 branch May 27, 2024 09:52
@maschmann maschmann mentioned this pull request Oct 1, 2024
maschmann added a commit that referenced this pull request Oct 1, 2024
* drop PHP versions below 8.1
* update dependencies
* merge fix for When using json() failing command has output on stdout and not stderr #90
* add symfony process 7 Adding support of symfony/process ^7.0 #94
* add docker env for develeopment
* update phpunit, fix tests to work with v11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant