Unclosed Session/SSLSocket

[sky-coding]

When I run the following python code with a debugger attached -

polygon_api = polygon.RESTClient()
response = polygon_api.stocks_equities_aggregates('AAPL', 30, 'minute', '2020-06-30', '2020-06-30')

I get a post-run warning from my debugger -

ResourceWarning: unclosed <ssl.SSLSocket type=SocketKind.SOCK_STREAM, raddr=('38.133.177.84', 443)>

But if I run -

polygon_api = polygon.RESTClient()
response = polygon_api.stocks_equities_aggregates('AAPL', 30, 'minute', '2020-06-30', '2020-06-30')
polygon_api._session.close()

The polygon client cleans up and my debugger is happy.

Looking into why this is, Session will only call its own close() from its __exit__ method, which is only called if the class is being used as a context manager (e.g. using with Session() as s: statement, as suggested by their docs) - and RESTClient is not using it in this manner, so close() is just never being called and resources are being left open.

[Achilles718611]

I got the same error.
When I run individual python file in terminal, it works.
But when I send request in background mode using Celery, I got following error.

raised unexpected: RecursionError('maximum recursion depth exceeded while calling a Python object',)

[Achilles718611]

I could finally solve problem.
This is related with dependency not this library self.
I used celery and dnspython 2.0.0 caused error.
I downgraded dnspython version to 1.16.0 and now it works.

[sky-coding]

@Achilles718611 I'm not using celery or dnspython, I still believe the issue to be RESTClient never calling the close() method on its Session. You may have just masked the issue by modifying upstream network behavior

[jbonzo]

@sky-coding please look at #37 and see if this satisfies your needs. This should handle properly cleaning up the http resources used

[sky-coding]

@jbonzo I pulled your branch and verified that the unclosed socket error is eliminated in the use case I provided when using RESTClient as a context manager (which you added support for). Thanks!