Skip to content

Conversation

@Ashetf2
Copy link

@Ashetf2 Ashetf2 commented Mar 10, 2025

Related Issue

ValveSoftware/Source-1-Games#4912. Yeah it's closed but it is still an issue, like the unused mvm responses.

Implementation

Creates a new response concept. Now if the player is touching the cart, the concept is MP_CONCEPT_CART_PUSHING, and they are not, it is MP_CONCEPT_CART_MOVING_FORWARD.

Unlike my submission in the workshop, this doesn't add any new voiceline that isn't supposed to play already, so no mvm voicelines or sf13. On the other hand, I've made some modifications, moved responses that aren't in their proper place, and rearranged others (essentialy limited "stay close to cart" responses for when you are not pushing)

Pyro and Engie are not included for now. If merged, I will make them, but very limited for Engie sadly

Screenshots

Desktop.2025.03.09.-.16.44.49.04.DVR.mp4
Desktop.2025.03.09.-.19.03.26.08.DVR.mp4
Desktop.2025.03.09.-.19.04.31.09.DVR.mp4
Desktop.2025.03.09.-.17.33.47.07.DVR.mp4

Checklist

  • No other PRs implement this idea.
  • This PR does not introduce any regressions.
  • I certify that this PR is my own entirely original work, or I have permission from and have attributed the relevant authors.
  • I have agreed to and signed this project's Contributor License Agreement.
  • This PR targets the tc2-mod branch.
  • This change has been filed as an issue.
  • No other PRs address this.
  • This PR is as minimal as possible.
  • This PR does not introduce any regressions.
  • This PR has been built and locally tested on at least one platform.
  • This PR has been tested on all platforms, on both a dedicated server and on a listen server.

Testing Checklist

Client Server Version
Windows yea 10
Linux

Ashetf2 added 4 commits March 10, 2025 00:36
Adds the cartpushingclass response.

Also, now the "stay close" only plays if the player is not touching the cart.

Also, organized the files a bit

Also also, moved some scene lines because some of them don't fit the actual response (e.g. scout cart moving forward defense voicelines)

Lastly, some scout responses don't play, so we use a simple fix
Bitl added a commit to BitlDevelopmentStudios/source-sdk-2013-bds-base that referenced this pull request May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant