Fix warning about shadow calculation in issue #114 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix @danieldunderfelt! I'm using this in production now and it works great. I hope this PR will get merged soon. |
|
@cooperka yeah it needed to be done. Cheers! |
|
good, someone tested it for me, even in production environment. let's merge it then. thanks @danieldunderfelt and @cooperka |
|
Hey guys... Any idea why I'm still having this problem in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #114 by removing the animated wrapper around the button icon and moving all those styles and animations to the button's outer View. An additional wrapping view was added to attach the shadow to.
Apparently an immediate child can provide the background in shadow calculations, so we do not need to attach a background to the shadow View.This wrapper also gets the buttonColor set as background to avoid the warning.As a side-effect, setting the
outRangeScalemakes the whole button scale rather than only the icon, which I consider a fix.Note that as of writing, I have only tested this PR on iOS (React-native 0.38) so I cannot say if #109 is affected in any way.