forked from davidtodd/landmarks
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for dynamic content changes #111
Merged
Merged
Commits on Oct 30, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d73b21c - Browse repository at this point
Copy the full SHA d73b21cView commit details -
* Compare element to undefined directly. * Improve the injected landmarks test page by adding nesting.
Configuration menu - View commit details
-
Copy full SHA for 4eab0ba - Browse repository at this point
Copy the full SHA 4eab0baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 011419d - Browse repository at this point
Copy the full SHA 011419dView commit details -
Make a test version; Lint with addons-linter
* This is for Firefox users, to test the MutationObserver stuff. * Use Mozilla addons-linter to check extensions before they are uploaded (currently Firefox only).
Configuration menu - View commit details
-
Copy full SHA for 9cfcb6f - Browse repository at this point
Copy the full SHA 9cfcb6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e9fc35 - Browse repository at this point
Copy the full SHA 4e9fc35View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc198e3 - Browse repository at this point
Copy the full SHA cc198e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfa8229 - Browse repository at this point
Copy the full SHA dfa8229View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44af02c - Browse repository at this point
Copy the full SHA 44af02cView commit details -
* Remove console output when disabling extension on certain URLs. * Remove the "loading" ("...") indicator from the badge (it should be robust enough not to need this, and it should not expose such internal details to the end-user). * Only say how long it took to find landmarks when they are (re-)found as a result of a MutationObserver. * Make LandmarksFinder.filter() cleaner using map().
Configuration menu - View commit details
-
Copy full SHA for 716ce99 - Browse repository at this point
Copy the full SHA 716ce99View commit details
Commits on Oct 31, 2017
-
Track selected element across dynamic page updates
This contributes to #84.
Configuration menu - View commit details
-
Copy full SHA for eba704d - Browse repository at this point
Copy the full SHA eba704dView commit details -
* Roll back to deepmerge 1.5.x due to change in behaviour TehShrike/deepmerge#83 * Add command definition for main-landmark. * Add translation text for main-landmark. * Simplify command handling in background script. * Make error throwing consistent.
Configuration menu - View commit details
-
Copy full SHA for f1331fa - Browse repository at this point
Copy the full SHA f1331faView commit details -
All seems well except addons-linter is complaining about PNGs, though they have always shown up fine...
Configuration menu - View commit details
-
Copy full SHA for 98554df - Browse repository at this point
Copy the full SHA 98554dfView commit details
Commits on Nov 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 35bf647 - Browse repository at this point
Copy the full SHA 35bf647View commit details -
Skip to main; Removing redundant code
* Remove unused this.currentLandmarkElement() from LandmarksFinder. * Track which element is the <main>/role="main" element. * Add this.selectMainElement() to LandmarksFinder. * Handle the 'main-landmark' message in content.management.js. * Add info on skipping to the main landmark to the README. This completes the work started in f1331fa and closes #106.
Configuration menu - View commit details
-
Copy full SHA for 05ec66f - Browse repository at this point
Copy the full SHA 05ec66fView commit details
Commits on Nov 3, 2017
-
Tidying comments; Mutation observer stuff
* Tidy up mutation observer setup stuff. * Remove a logic error (spurious `return false`) from mutation observer mutation handler code. * Make comments and spacing consistent.
Configuration menu - View commit details
-
Copy full SHA for f82132f - Browse repository at this point
Copy the full SHA f82132fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 902c52b - Browse repository at this point
Copy the full SHA 902c52bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.