[BottomNavigationView] shouldn't calculate bottom system insets when keyboard popup in adjustResize

[b95505017]

In 1.1.0-alpha09:

Update BottomNavigation to respect bottom system insets (276bec8)

I found that in adjustResize mode, BottomNavigationView will be pushed up aligned with keyboard popped up, and insets.getSystemWindowInsetBottom() will be keyboard hight, causing BottomNavigationView increase padding bottom to double keyboard hight from screen bottom.

[dsn5ft]

@b95505017 Thanks for reporting, can you attach a screenshot?

[b95505017]

https://imgur.com/a/2N3rm1A Here are the two layout layers between 1.1.0-alpha08 and 1.1.0-alpha09.

[wcshi]

@b95505017 could you either provide a sample app or explain your layout so I can reproduce this behavior?

[b95505017]

I'll try to provide a sample, but basically it has several points:

1. The windowSoftInputMode is adjustResize.
2. A layout which has EditText placed near top and BottomNavigationView at the bottom.
3. When keyboard popup, the window and the layout are resized( the bottom of the layout aligned with the top of the keyboard), while BottomNavigationView received onApplyWindowInsets( insets.getSystemWindowInsetBottom() is the height of keyboard, e.g. 740px), so that BottomNavigationView padding bottom will be 740px.
4. From screen bottom, there will be 740px keyboard + 740px padding, then the real content of BottomNavigationView.

[paolovalerdi]

Not only that. If your app is launched with the keyboard open (let's say from the launcher searcher) then the BottomNavigationView will get the keyboard height as the initial systemBottomInset as the bottom padding.

[rhariskumar3]

In 1.1.0-alpha09:

Update BottomNavigation to respect bottom system insets (276bec8)

I found that in adjustResize mode, BottomNavigationView will be pushed up aligned with keyboard popped up, and insets.getSystemWindowInsetBottom() will be keyboard hight, causing BottomNavigationView increase padding bottom to double keyboard hight from screen bottom.

@b95505017 Thanks for reporting, can you attach a screenshot?

My Bottom Navigation also changed bad.
alpha-09 - Bottom Nav View - Screenshot

[wcshi]

@rhariskumar3 what API version is your emulator? What system ui flags are set in your app?

[b95505017]

@wcshi Here is the sample of adjustResize

My workaround is extend BottomNavigationView and remove insets listener:

class BottomNavigationViewFix: BottomNavigationView {
    constructor(context: Context?) : super(context)
    constructor(context: Context?, attrs: AttributeSet?) : super(context, attrs)
    constructor(context: Context?, attrs: AttributeSet?, defStyleAttr: Int) : super(
        context,
        attrs,
        defStyleAttr
    )

    init {
        setOnApplyWindowInsetsListener(null)
    }
}

[rhariskumar3]

@rhariskumar3 what API version is your emulator? What system ui flags are set in your app?

Emulator API version 29
Code - Screenshot

[wcshi]

@paolovalerdi could you please file a separate issue with steps to produce the bug and sample app, thank you

[chrisbanes]

Just checked the sample from @b95505017 above. The reason this is happening is because of the following layout (my comments inline).

<!-- The CoordinatorLayout is set to fitsSystemWindows  -->
<androidx.coordinatorlayout.widget.CoordinatorLayout
    android:fitsSystemWindows="true">

    <!-- The direct child of the CoordinatorLayout is NOT set to
         fitsSystemWindows, this means that CoL will automatically
         move this view up to match the insets. This is the first
         application of the insets. -->
    <androidx.constraintlayout.widget.ConstraintLayout>

        <!-- The descendent BottomNavigationView is passed the same insets,
             and pads itself. This is the second application. -->
        <com.google.android.material.bottomnavigation.BottomNavigationView />

    </androidx.constraintlayout.widget.ConstraintLayout>

</androidx.coordinatorlayout.widget.CoordinatorLayout>

So how do you fix it?
Two options:

1. Move the BottomNavigationView up to be a child of the CoordinatorLayout, and set it to fitsSystemWindows="true"
2. Set the ConstraintLayout to fitsSystemWindows="true" AND set an OnApplyWindowInsetsListener on it to ignore the inset (so that only the BottomNavigation handles it). Slide 143 from this talk goes through a similar example.

[wcshi]

Thanks @chrisbanes closing issue.