- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
fix: select shape #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: select shape #107
Conversation
| 
           Closes #69  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a spelling error in function names and updates the shape handling architecture. The main purpose is to correct the misspelled "parseElipse" to "parseEllipse" and refactor shape management by moving state out of individual shape objects into a centralized location.
- Corrected spelling of "parseElipse" to "parseEllipse" across TypeScript files
 - Refactored shape state management by moving preview points and active path tracking to global state
 - Updated function signatures to use centralized points arrays instead of image objects
 
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description | 
|---|---|
| src/shapes/parseEllipse.ts | Fixed function name spelling from "parseElipse" to "parseEllipse" | 
| src/shapes/createShape.ts | Updated import and function call to use correct "parseEllipse" spelling | 
| src/logic/transform_ui.zig | Refactored functions to accept points array instead of image objects | 
| src/logic/shapes/shapes.zig | Major refactor moving state management out of Shape struct to centralized location | 
| src/logic/shapes/paths.zig | Removed redundant comment | 
| src/logic/index.zig | Updated to use centralized state management and consistent naming conventions | 
| src/WebGPU/pointer.ts | Updated function call to match new naming convention | 
Comments suppressed due to low confidence (2)
src/logic/index.zig:60
- The constant name 'NO_SELECTION' should follow Zig naming conventions and be lowercase with underscores: 'no_selection'.
 
const NO_SELECTION = 0;
src/logic/index.zig:61
- The constant name 'MIN_NEW_CONTROL_POINT_DISTANCE' should follow Zig naming conventions and be lowercase with underscores: 'min_new_control_point_distance'.
 
const MIN_NEW_CONTROL_POINT_DISTANCE = 10.0; // Minimum distance to consider a new control point
| 
          
 Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the  You can disable this status message by setting the  ✨ Finishing Touches🧪 Generate unit tests
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit: 
 SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
 Other keywords and placeholders
 CodeRabbit Configuration File (
 | 
    
No description provided.