-
Notifications
You must be signed in to change notification settings - Fork 25
optimizations #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimizations #153
Conversation
CohenCyril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Do you agree that the coercion problem is still there? |
|
I did not check yet... but from the big term you showed, it seems so... |
|
in the term above, the small but not optimal one |
|
Maybe we should reverse the list of coercion declaration? |
|
IMO it is mixin-src / mterm->term which does things in the wrong order |
|
or maybe not, but the coercion order seems OK according to @pi8027 |
|
and you saw that thanks to the logger? |
|
Print Graph. |
the first one brings down the last instance in ssralg to 0.4s, slow but tolerable.
the second one is just to avoid being silly and store
s.phant_Build crapinstead ofs.Build less crap, it does not impact performances too much for not.I believe the root problem is still there:
This instance is where the "coercion chain problem" pops up and is still manageable, hence were we can debug it.
(FTR: before this PR this term was already gigantic and contained
phant_Build crap)CC @CohenCyril @pi8027