-
Notifications
You must be signed in to change notification settings - Fork 25
No section discharge for alias factories and builder mixins #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b4eaea1 to
d0cb16c
Compare
f25c189 to
ebe00df
Compare
|
Attributes are only looked up in the hypothetical context, not the whole program. Your intuition is nice, but I don't think I can implement it :-/ |
It's ok I invented a new clause dedicated to that... My main problem is understanding how to work around rocq-prover/rocq#13903, but «c'est casse-gueule». |
|
Something is fishy, vars should be closed wrt their type. |
|
You could use the code I wrote to discharge by hand record factories, a part of it actually... |
Actually, your trick for factories relied on the fact that the factory was not used in the section it was defined in. So that you can close the section and rebuild the record after that. However we cannot do this for builder instances because they are gradually used in the same section. |
|
I can maybe fix @using! In coq Elpi waiting for the fix in coq proper... But next week :-) |
|
What should we do with this PR? The coq issue is closed (in 8.14) and |
c0ab571 to
6a971c5
Compare
|
@CohenCyril it may be nice to have a test for this feature in the test suite, can you add it? |
This is not a fix for #182. But it still makes sense