Skip to content

Conversation

@proux01
Copy link
Contributor

@proux01 proux01 commented May 30, 2023

Fixes #349

Copy link
Member

@gares gares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@proux01
Copy link
Contributor Author

proux01 commented May 30, 2023

Let me fix the CI, the config seems outdated

@proux01 proux01 force-pushed the missing_join_message branch 3 times, most recently from 917ca2e to 7710bc0 Compare May 30, 2023 15:20
@proux01
Copy link
Contributor Author

proux01 commented May 31, 2023

@gares still not perfect but I guess the CI can be considered green enough to merge

@proux01 proux01 force-pushed the missing_join_message branch from 7710bc0 to 08dfc99 Compare May 31, 2023 07:55
@gares gares merged commit 9dd967e into math-comp:master May 31, 2023
@proux01 proux01 deleted the missing_join_message branch May 31, 2023 12:36
@proux01 proux01 mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error message about missing join

2 participants