Do not spill predicates defined in files accumulated after the spilling #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
force-pushed
the
fix-spill-next-coq-elpi
branch
2 times, most recently
from
1e306c4 to
b6b5ac1
Compare
gares
changed the title
Member
Contributor
|
My understanding is that previous versions of Elpi did allow spilling even in predicates that didn't exist yet whereas the future Elpi (that we need to get acceptable performances) no longer accepts it. |
Contributor
|
@CohenCyril c.f. the changelog of LPCIC/coq-elpi#469 |
Member
Author
|
I want this to be merged so that I can test LPCIC/coq-elpi#393 |
Member
Author
|
@proux01 wasn't the diff failure fixed in master? I don't get this |
Contributor
|
@gares it's because the commit is cherry-picked from the coq-master branch. The change on |
gares
force-pushed
the
fix-spill-next-coq-elpi
branch
from
b6b5ac1 to
6a48660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.