-
Notifications
You must be signed in to change notification settings - Fork 25
separate synterp phase #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think the removal of |
|
Ok |
| % is this a bug? | ||
| % coq.env.current-library File, | ||
| % coq.elpi.accumulate current "export.db" (clause _ _ (module-to-export File "" O)). | ||
| true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CohenCyril is this a bug in HB.structure?
The module MathCompCompatFoo is exported here, but not when one issues HB.reexport.
Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snippet is outdated, but the question still valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a bug indeed, I think it should be marked to be exported via HB.reexport
7ed9b59 to
e961027
Compare
8a5c6bb to
3278574
Compare
|
I think this PR is ready now, although still blocked by the release of coq-elpi 2.0. I'm dropping 8.17 support. The only problem is that now the two phases need to be in sync, and we do generate random module names. Coq-Elpi 2 has a commodity API which lets one randomize the name at synterp time, and just reuse the same name at interp time. |
|
Please merge now |
Since Coq 8.18 the parsing (synterp) phase of commands must be separate from the execution one (interp).
The synterp phase must declare operations on module and section (and notations, be we don't have them).
Only Coq-Elpi 2.0 has (will have) support for this feature. See LPCIC/coq-elpi#557
This PR fixes HB when used with Vscoq2.
This PR removes the code of HB.lock and rebinds elpi.apps.locker(mlock) to that name.