Skip to content

Conversation

@Tvallejos
Copy link
Contributor

@Tvallejos Tvallejos commented Jul 23, 2024

At CUDW 2024, we discussed the idea of ​​writing a guide for declaring mathcomp instances.
This PR refers to that guide.

@CohenCyril
Copy link
Member

Looks good to me in principle. However HB is meant to be used outside of math-comp. Shouldn't the command refer to a doc in HB wiki rather than math-comp wiki?

@Tvallejos
Copy link
Contributor Author

It is true, there are conflicting interests. On the one hand, HB is used outside of mathcomp. And on the other hand, mathcomp uses HB to declare its instances. We thought with @gares of adding this link to the HB message so that it would be easy to reach for mathcomp users.
Regarding the guide's location, the guide has a section that is only valid for mathcomp, because it uses definitions that are in mathcomp files. I think it would be less convenient to put it on the HB wiki.

@gares
Copy link
Member

gares commented Jul 23, 2024

The message talks about math comp explicitly, so I don't think it is too misguiding.

@Tvallejos Tvallejos requested a review from gares July 25, 2024 15:27
Copy link
Member

@gares gares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gares gares closed this Jul 26, 2024
@gares gares reopened this Jul 26, 2024
@gares gares merged commit 1c6f7e1 into math-comp:master Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants