Skip to content

Conversation

@gares
Copy link
Member

@gares gares commented Nov 20, 2024

@gares gares force-pushed the elpi-2.0 branch 2 times, most recently from 9b19687 to ab3ec8e Compare November 21, 2024 08:46
@gares gares marked this pull request as ready for review November 21, 2024 15:56
@gares
Copy link
Member Author

gares commented Nov 21, 2024

The main downside is that I had to remove Elpi Typecheck, since it emits a warning that is made fatal.
Otherwise the changes look reasonable to me.
The new type checker discovered some circularity in the file dependencies, nothing dramatic.

@gares
Copy link
Member Author

gares commented Nov 21, 2024

@Tragicus @CohenCyril this update to the software stack should make the coercion/cs elpi hooks much faster to call. If you are still working on these it may be worth giving it a try.

@gares
Copy link
Member Author

gares commented Nov 22, 2024

I forgot I could disable the warning about Elpi Typecheck, now this PR can be merged with no downsides.

@gares gares merged commit c58f776 into master Nov 22, 2024
125 checks passed
@gares gares deleted the elpi-2.0 branch November 22, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants