Skip to content

Conversation

@gares
Copy link
Member

@gares gares commented Mar 11, 2020

Two things to do:

  • demo2 has an error since TAddAG is also a definition (before it becomes a structure). @CohenCyril I let you decide what to do
  • We need to replace all F.axioms by F in the files

Question:

  • now Foo is the type of the factory, while Foo.Axioms is the constructor. Maybe we should rename/alias it to something nicer? Foo.Build maybe? The last commit implements it, it is easy to drop

@gares gares requested a review from CohenCyril March 11, 2020 09:58
@CohenCyril
Copy link
Member

  • demo2 has an error since TAddAG is also a definition (before it becomes a structure). @CohenCyril I let you decide what to do

The typealias TAddAG should be renamed tAddAG

@gares
Copy link
Member Author

gares commented Mar 11, 2020

Well, I've added a trailing _, feel free to push here

Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gares gares merged commit 129f0a3 into master Mar 11, 2020
@gares gares deleted the factory-short-abbrev branch March 11, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants