Complex Multigeometries In/Out #110
Conversation
mtezzele
left a comment
mtezzele
left a comment
There was a problem hiding this comment.
Please add some tests in order to verify that everything is working fine.
The occ version currently supported by pygem is 0.17. Let me know if you need the last version.
pygem/nurbshandler.py
Outdated
| TopAbs_FORWARD, TopAbs_SHELL) | ||
| from OCC.TopExp import (TopExp_Explorer, topexp) | ||
| from OCC.gp import (gp_Pnt, gp_XYZ) | ||
| from OCC.BRep import * |
There was a problem hiding this comment.
See quantified code for suggestion on how to avoid the import using *
pygem/nurbshandler.py
Outdated
| from OCC.gp import (gp_Pnt, gp_XYZ) | ||
| from OCC.BRep import * | ||
| from OCC.TColgp import (TColgp_Array1OfPnt, TColgp_Array2OfPnt) | ||
| from OCC.BRepOffsetAPI import * |
pygem/nurbshandler.py
Outdated
| self.write_shape_to_file(compound, self.outfile) | ||
|
|
||
|
|
||
| def parse_face(self, topo_face): |
There was a problem hiding this comment.
You never use self in this method. Make it a static method (see quantified code). Also the methods below have the same problem.
pygem/nurbshandler.py
Outdated
| :return: mesh_points_edge: it is a list of `n_points`-by-3 matrix | ||
| :rtype: numpy.ndarray and list |
There was a problem hiding this comment.
Actually it is a dictionary
| :param topo_face: the input Face | ||
| :return: mesh_points_face: it is a `n_points`-by-3 matrix containing the |
There was a problem hiding this comment.
You can merge these two returns by creating a single variable that will be returned. Please check also the other methods.
|
Any news @zjiang0529 ? |
|
Hello, thanks for the remind. We are going to commit a new version soon. |
|
Hello, we have just committed some modification. |
|
@zjiang0529 please add some tests in order to verify that everything is working fine. |
3 participants
Hi! We have pushed a first version of adding multi-geometries features.
(Issue #109)
Thanks.