Add Polyharmonic Spline to RBF class #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndem0
force-pushed
the
polyharmonic
branch
2 times, most recently
from
fa3ee08 to
3f8fd92
Compare
mtezzele
reviewed
May 19, 2017
pygem/radial.py
Outdated
| if k & 1: return power(r_sc, k) # k odd | ||
|
|
||
| # Here, k is even | ||
| if r < 1: return power(r_sc, k-1) * np.log(power(r_sc, r_sc)) |
Collaborator
There was a problem hiding this comment.
here the correct check is: if r_sc < 1
ndem0
force-pushed
the
polyharmonic
branch
3 times, most recently
from
ae9200b to
8cb79f5
Compare
- implement polyharmonic spline - add the tests for the new function - add `power` parameter for RBFParameter - adjust the parameter files - clean some docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
powerparameter for RBFParameter