unvhandler and freeform #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pygem/unvhandler.py
Outdated
| if line.startswith(' 2411'): | ||
| index = num | ||
| if num == index + 2: | ||
| if line.startswith(' -1'): |
Collaborator
There was a problem hiding this comment.
I think that inside startswith there are spaces, not a tab. Same below at line 85. This should solve the error in the unv tests.
DavideBaroliUniLu
pushed a commit
to DavideBaroliUniLu/PyGeM
that referenced
this pull request
Oct 11, 2016
* improved performance in freeform (~25%) * fixed bug and improved flexibility in unvhandler * new write comparison in unv tests
mtezzele
pushed a commit
that referenced
this pull request
May 17, 2017
* improved performance in freeform (~25%) * fixed bug and improved flexibility in unvhandler * new write comparison in unv tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mtezzele @fsalmoir
unvhandler: there is an important bug in the parsing of the mesh points. The last node (mesh point) is stored as (0., 0., 0.), instead of the actual value. Furthermore, it was not very flexible as it could only read the .unv file provided with the tutorial, and not, for instance, one generated with gmsh. I modified significantly the code to improve this feature.
freeform: I changed the code simply in order to apply the free form deformation only to those nodes inside the box domain. The performance greatly benefits.